Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/1997?usp=email )
Change subject: buffer: Fix small issues buf_printf and buf_puts ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Commit Message: https://gerrit.openvpn.net/c/openvpn/+/1997/comment/bf44caf2_47911318?usp=email : PS1, Line 7: buffer: Fix small issues buf_printf and buf_puts Is this missing an "in"? File src/openvpn/buffer.h: https://gerrit.openvpn.net/c/openvpn/+/1997/comment/3d7b7dff_7cce7db7?usp=email : PS1, Line 795: * @return true if the buffer was changed, i.e. at least one character was appended. `buf_puts(buf, "")` returns `true` whenever `cap > 1` so that's not technically true. Maybe say "false if there was no room to append anything"? File tests/unit_tests/openvpn/test_buffer.c: https://gerrit.openvpn.net/c/openvpn/+/1997/comment/af54758a_5f5c3f0d?usp=email : PS1, Line 68: assert_buf_equals_str(&buf, "123some text, t"); This passes with the old code as well. Intended? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1d6ed5d40910359b65b9f5c5d8f56ad3d3bc827a Gerrit-Change-Number: 1997 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 14 Oct 2026 07:13:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
