Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/1996?usp=email )
Change subject: Replace strncat with strlcat ...................................................................... Patch Set 2: (3 comments) File src/plugins/auth-pam/utils.c: https://gerrit.openvpn.net/c/openvpn/+/1996/comment/732262b6_10070ac2?usp=email : PS1, Line 75: char temp[templen + 1] = { 0 }; > This is a variable-length array, and C11 doesn't allow that, so GCC 16 > rejects it: […] Done https://gerrit.openvpn.net/c/openvpn/+/1996/comment/278eac39_89b3cdd2?usp=email : PS1, Line 83: memcpy(target, replacewith, replacewithlen); > `target` isn't advanced after copying `replacewith`. […] Done https://gerrit.openvpn.net/c/openvpn/+/1996/comment/60fd9ac5_4193ef20?usp=email : PS1, Line 85: searching = scratch + tosearchlen; > Shouldn't we use the length of `searchfor` here? Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I61e29dd2af9302b240c93735179d43c72e37b335 Gerrit-Change-Number: 1996 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Wed, 14 Oct 2026 11:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
