Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2010?usp=email
to review the following change.
Change subject: gen-sample-keys.sh: use a random serial
......................................................................
gen-sample-keys.sh: use a random serial
Instead of forcing openssl to create consecutive serial numbers, let it
generate random serials. Although not really relevant for the sample keys,
that is the best practice.
Signed-off-by: Steffan Karger <[email protected]>
Change-Id: Ic36123c5a4a2b2295ffdf47174e2aceb9d17d668
---
M sample/sample-keys/gen-sample-keys.sh
M sample/sample-keys/openssl.cnf
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/10/2010/1
diff --git a/sample/sample-keys/gen-sample-keys.sh
b/sample/sample-keys/gen-sample-keys.sh
index e5a11f5..e914fd2 100755
--- a/sample/sample-keys/gen-sample-keys.sh
+++ b/sample/sample-keys/gen-sample-keys.sh
@@ -22,7 +22,6 @@
mkdir -p sample-ca
rm -f sample-ca/index.txt
touch sample-ca/index.txt
-echo "01" > sample-ca/serial
# Generate CA key and cert
openssl req -new -newkey rsa:4096 -days 3650 -nodes -x509 \
diff --git a/sample/sample-keys/openssl.cnf b/sample/sample-keys/openssl.cnf
index 02bf8ac..dcaebb7 100644
--- a/sample/sample-keys/openssl.cnf
+++ b/sample/sample-keys/openssl.cnf
@@ -14,7 +14,7 @@
new_certs_dir = $dir # default place for new certs.
certificate = $dir/ca.crt # The CA certificate
-serial = $dir/serial # The current serial number
+rand_serial = yes # Use random serial numbers
crl = $dir/crl.pem # The current CRL
private_key = $dir/ca.key # The private key
RANDFILE = $dir/.rand # private random number file
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2010?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic36123c5a4a2b2295ffdf47174e2aceb9d17d668
Gerrit-Change-Number: 2010
Gerrit-PatchSet: 1
Gerrit-Owner: Steffan Karger <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
