Attention is currently required from: Arne Schwabe. Antonio Quartulli has posted comments on this change by Antonio Quartulli. ( https://gerrit.openvpn.net/c/openvpn/+/1786?usp=email )
Change subject: multi: assign IPv6 addresses from a tagged subnet-pool ...................................................................... Patch Set 7: PS7: cppcheck cleanup only, no functional change. - options.c: the --subnet-pool-ipv6 prefix-length error message used %d for the unsigned netbits; now %u (invalidPrintfArgType_sint). - multi.c: multi_get_group_pool() picked the pool tag with "d4 ? d4->tag : d6->tag", safe only because of the preceding ASSERT(d4 || d6), which cppcheck does not model (nullPointerRedundantCheck); the tag is now chosen with an explicit NULL check and asserted. - test_subnet_pool.c: one pair of pool definitions per scenario in the IPv6 test, as in 1783 (redundantAssignment). With this, "make cppcheck CPPCHECK_CHECK_LEVEL=normal" reports no new findings for any patch of the series compared to master. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I64e0850d48647a2c0e3d385c2f20a9f445931727 Gerrit-Change-Number: 1786 Gerrit-PatchSet: 7 Gerrit-Owner: Antonio Quartulli <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Sun, 18 Oct 2026 11:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
