Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2023?usp=email
to review the following change.
Change subject: Fix broken unit tests after commit 5c6fbd0a11
......................................................................
Fix broken unit tests after commit 5c6fbd0a11
Said commit only cherry-picked the "actual code change" but not the
required adjustments for the unit tests, leading to an unresolved symbol.
Master has all the mock functions in mock_push_dependencies.c which
does not exist in release/2.7, so import "uninit_options()" into the
actual unit test source (as are all the other mocked functions in 2.7)
Change-Id: I7f2db60564fa179ce5f56979912c7e484dad1e1d
Signed-off-by: Gert Doering <[email protected]>
---
M tests/unit_tests/openvpn/test_push_update_msg.c
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/2023/1
diff --git a/tests/unit_tests/openvpn/test_push_update_msg.c
b/tests/unit_tests/openvpn/test_push_update_msg.c
index 9b7978e..75b654b 100644
--- a/tests/unit_tests/openvpn/test_push_update_msg.c
+++ b/tests/unit_tests/openvpn/test_push_update_msg.c
@@ -48,6 +48,13 @@
return;
}
+void
+uninit_options(struct options *options)
+{
+ gc_free(&options->gc);
+ gc_free(&options->dns_options.gc);
+}
+
bool
options_postprocess_pull(struct options *options, struct env_set *es)
{
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2023?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: release/2.7
Gerrit-Change-Id: I7f2db60564fa179ce5f56979912c7e484dad1e1d
Gerrit-Change-Number: 2023
Gerrit-PatchSet: 1
Gerrit-Owner: Gert Doering <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
