Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2028?usp=email
to review the following change.
Change subject: configure: Call AC_PROG_CC before AC_USE_SYSTEM_EXTENSIONS
......................................................................
configure: Call AC_PROG_CC before AC_USE_SYSTEM_EXTENSIONS
AC_USE_SYSTEM_EXTENSIONS requires AC_PROG_CC, so the later explicit
call expanded it a second time and repeated the C standard checks
as "(cached)".
Change-Id: I20d367dd8251bf39856ae521f380cfdc8df64177
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M configure.ac
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/2028/1
diff --git a/configure.ac b/configure.ac
index e31a7ff..0ac61b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,6 +45,11 @@
AM_INIT_AUTOMAKE(foreign subdir-objects 1.16) dnl NB: Do not [quote] this
parameter.
AM_SILENT_RULES([yes])
AC_CANONICAL_HOST
+AC_PROG_CC
+# AC_PROG_CC doesn't output any useful information
+AC_MSG_CHECKING([compiler version])
+CC_version=$($CC --version | head -n1)
+AC_MSG_RESULT([$CC_version])
AC_USE_SYSTEM_EXTENSIONS
AM_EXTRA_RECURSIVE_TARGETS([build-tests])
@@ -380,11 +385,6 @@
pkg_config_found="(${PKG_CONFIG})"
fi
-AC_PROG_CC
-# AC_PROG_CC doesn't output any useful information
-AC_MSG_CHECKING([compiler version])
-CC_version=$($CC --version | head -n1)
-AC_MSG_RESULT([$CC_version])
AC_PROG_CPP
AC_PROG_INSTALL
AC_PROG_LN_S
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2028?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I20d367dd8251bf39856ae521f380cfdc8df64177
Gerrit-Change-Number: 2028
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
