Thanks for helping us fix our bugs :-)
Patch looks good, has a formal +2 from Heiko as "primary owner of that code",
and passes our test compiles just fine - didn't go out and test if how it
would change handling of overlong strings in practice.
More generally speaking there is quite a bit of inconsistency here in
how the Handle*Message() functions get their arguments - some declare
this as a "const *" and then cast this to a non-const pointer to
do the null-termination, others (like HandleAddressMessage()) get a
non-const pointer, and directly modify the structure in place.
This definitely needs a more clear function contract... (not a problem
of your patch, but when I look at things, I tend to find something...)
Your patch has been applied to the master and release/2.7 branch.
commit 5e520ccb3df9e2f3eb79e2a47d62d014bce5b9b8 (master)
commit 323bc64b98542ba74a64fc3450894b260eea36d6 (release/2.7)
Author: Naveed Khan
Date: Wed Oct 21 18:57:29 2026 +0200
interactive: null-terminate iface.name in address and route handlers
Signed-off-by: Naveed Khan <[email protected]>
Signed-off-by: Lev Stipakov <[email protected]>
Acked-by: Heiko Hund <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2027
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg40085.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
