Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2128?usp=email
to review the following change.
Change subject: openvpnserv: don't return freed token groups from
GetTokenGroups()
......................................................................
openvpnserv: don't return freed token groups from GetTokenGroups()
When the second GetTokenInformation() call failed, the freed buffer was
returned. IsUserInGroup() then read it and IsAuthorizedUser() freed it
again. Return NULL, which IsUserInGroup() already handles by skipping
the token group check.
Broken since e82733a1 ("Fix user's group membership check in
interactive service to work with domains").
Change-Id: I5542520825112dfd64aab332bd76333b74d7fec0
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpnserv/validate.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/2128/1
diff --git a/src/openvpnserv/validate.c b/src/openvpnserv/validate.c
index 6a13a06..2858f62 100644
--- a/src/openvpnserv/validate.c
+++ b/src/openvpnserv/validate.c
@@ -227,6 +227,7 @@
{
MsgToEventLog(M_SYSERR, L"GetTokenInformation");
free(groups);
+ groups = NULL;
}
return groups;
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2128?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5542520825112dfd64aab332bd76333b74d7fec0
Gerrit-Change-Number: 2128
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
