Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2125?usp=email
to review the following change.
Change subject: manage: drop unused input parameter of
management_query_multiline()
......................................................................
manage: drop unused input parameter of management_query_multiline()
The parameter has never been used since the function was added in
39e3d336 ("Mac OS X Keychain management client"). Its callers read the
input list themselves.
Change-Id: I40059eb9af845a5070ebb8caff741b0794632de2
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/manage.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/25/2125/1
diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 58f63e6..57a9561 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -3830,7 +3830,7 @@
static int
management_query_multiline(struct management *man, const char *b64_data, const
char *prompt,
- const char *cmd, int *state, struct buffer_list
**input)
+ const char *cmd, int *state)
{
struct gc_arena gc = gc_new();
int ret = 0;
@@ -3914,7 +3914,7 @@
int ok;
char *result = NULL;
- ok = management_query_multiline(man, b64_data, prompt, cmd, state, input);
+ ok = management_query_multiline(man, b64_data, prompt, cmd, state);
if (ok && buffer_list_defined(*input))
{
buffer_list_aggregate_separator(*input, 10000, "\n");
@@ -3941,7 +3941,7 @@
{
char *result = NULL;
- const int ok = management_query_multiline(man, b64_data, prompt, cmd,
state, input);
+ const int ok = management_query_multiline(man, b64_data, prompt, cmd,
state);
if (ok && buffer_list_defined(*input))
{
buffer_list_aggregate(*input, 2048);
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2125?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I40059eb9af845a5070ebb8caff741b0794632de2
Gerrit-Change-Number: 2125
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
