From: Razvan Cojocaru <[email protected]>

compv2_escape_data_ifneeded() wrote COMP_ALGV2_UNCOMPRESSED (the
algorithm id, 10) instead of COMP_ALGV2_UNCOMPRESSED_BYTE (0) after
the 0x50 indicator. Receivers reject that header, so packets whose
first byte is 0x50 were dropped with stub-v2 and lz4-v2, e.g. tap
frames to a MAC address starting with 0x50.

Broken since a75bb2e4 ("Implement the compression V2 data format for
stub and lz4.").

Change-Id: I784f3ffe17ecadabf96caad11fe9f774aa00b7cc
Signed-off-by: Razvan Cojocaru <[email protected]>
Acked-by: Arne Schwabe <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2142
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2142
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]>

        
diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c
index 387a7c4..513a766 100644
--- a/src/openvpn/comp.c
+++ b/src/openvpn/comp.c
@@ -100,7 +100,7 @@
 
     head = BPTR(buf);
     head[0] = COMP_ALGV2_INDICATOR_BYTE;
-    head[1] = COMP_ALGV2_UNCOMPRESSED;
+    head[1] = COMP_ALGV2_UNCOMPRESSED_BYTE;
 }
 
 


_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to