Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2156?usp=email
to review the following change.
Change subject: dco_linux: clear the context, not the pointer, in
ovpn_dco_uninit_netlink()
......................................................................
dco_linux: clear the context, not the pointer, in ovpn_dco_uninit_netlink()
CLEAR(dco) zeroes the local pointer variable instead of the
dco_context_t it points to, so the context keeps the nl_cb and
nl_cb_notify pointers that were just released with nl_cb_put().
No functional change today, since close_tun() frees the tuntap right
after, but use CLEAR(*dco) as intended.
GitHub: closes OpenVPN/openvpn#1143
Assisted-by: Claude Code:claude-opus-5-5
Change-Id: Idb22f731a00158ff020a819081a07e1235d8323d
Signed-off-by: Alexandre Laroche <[email protected]>
---
M src/openvpn/dco_linux.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/56/2156/1
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c
index 4412ad0..a84e310 100644
--- a/src/openvpn/dco_linux.c
+++ b/src/openvpn/dco_linux.c
@@ -537,7 +537,7 @@
nl_cb_put(dco->nl_cb);
nl_cb_put(dco->nl_cb_notify);
- CLEAR(dco);
+ CLEAR(*dco);
}
int
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2156?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb22f731a00158ff020a819081a07e1235d8323d
Gerrit-Change-Number: 2156
Gerrit-PatchSet: 1
Gerrit-Owner: Alexandre Laroche
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
