Attention is currently required from: Arne Schwabe, [email protected]. Selva Nair has posted comments on this change by [email protected]. ( https://gerrit.openvpn.net/c/openvpn/+/2148?usp=email )
Change subject: Implement multiline responses for pkcs11-id commands ...................................................................... Patch Set 2: (5 comments) Patchset: PS1: > Apart from comments below, in management-notes.txt, under OUTPUT_FORMAT no. > […] Done Patchset: PS2: I tried re-pushing this to trigger the Buildbot runs, but got: error: remote unpack failed: error Missing tree f6bb98471e275a4c88b6e8d969015945b6cebff5 Does anyone know how to resolve this? The patch looks good now. The commit message mentions the new management version, but could you make the compatibility behavior explicit: the new command forms and response format apply only to clients announcing version >= 7; older clients retain the existing behavior. Sorry I missed this in the earlier review. File doc/management-notes.txt: https://gerrit.openvpn.net/c/openvpn/+/2148/comment/5fdea454_4e3a2211?usp=email : PS1, Line 631: END > Describe the protocol in the both cases separately from examples? Like: […] Done https://gerrit.openvpn.net/c/openvpn/+/2148/comment/8366e0e0_e327e8ff?usp=email : PS1, Line 641: Example for client version < 7: > This section is confusing. […] Done File src/openvpn/manage.c: https://gerrit.openvpn.net/c/openvpn/+/2148/comment/1392ebf8_0d4fbd3f?usp=email : PS1, Line 918: > Two helpers split a small parsing operation, interpret the start argument > twice, and mix parsing wit […] Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2148?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I09e55085cde6dbc0040e111a42128527d59832b8 Gerrit-Change-Number: 2148 Gerrit-PatchSet: 2 Gerrit-Owner: [email protected] Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Selva Nair <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: [email protected] Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Sun, 08 Nov 2026 16:10:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Selva Nair <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
