Attention is currently required from: Antonio Quartulli, Gert Doering, Răzvan Cojocaru.
Arne Schwabe has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/2105?usp=email ) Change subject: Move gc from openvpn_net_ctx_t to local variables ...................................................................... Patch Set 2: (1 comment) File src/openvpn/networking_iproute2.c: https://gerrit.openvpn.net/c/openvpn/+/2105/comment/3c838f4f_9008f0c9?usp=email : PS1, Line 367: struct gc_arena gc = gc_new(); > technically we can just go without a `gc_arena()` in all these places - > `print_in6_addr()` uses `gc_ […] djpig basically broke calling print_in_addr_t and print_in6_addr with a NULL gc as they now return const char and you cannot free const char strings So in order to get rid of the gc_arena I would need to revert that print_in6_addr and print_in_addr_t return const strings I instead about to reuse the gc inside argv instead adding an extra gc in these function for the new version. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I494a427924ea501382275ea96ef85a6abcd780e5 Gerrit-Change-Number: 2105 Gerrit-PatchSet: 2 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Antonio Quartulli <[email protected]> Gerrit-Reviewer: Gert Doering <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Antonio Quartulli <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Gert Doering <[email protected]> Gerrit-Comment-Date: Fri, 06 Nov 2026 12:22:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Gert Doering <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
