Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2144?usp=email
to review the following change.
Change subject: openvpnserv: close the NRPT base key in
HandleDNSConfigNrptMessage()
......................................................................
openvpnserv: close the NRPT base key in HandleDNSConfigNrptMessage()
The key opened by OpenNrptBaseKey() was never closed, leaking a
registry handle on every NRPT add message. Close it at the common
exit, and return directly if opening fails, as the key is not set
then.
Broken since 0f3b7d17 ("win: implement --dns option support with
NRPT").
Change-Id: Ib7b9f2994ca828ea699bc6e5b08193dd30965926
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpnserv/interactive.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/44/2144/1
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index 6a83bac..81205d6 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3014,7 +3014,7 @@
LSTATUS err = OpenNrptBaseKey(&key, &gpol_nrpt);
if (err)
{
- goto out;
+ return err;
}
/* Add undo information first in case there's no heap left */
@@ -3065,6 +3065,7 @@
ApplyDnsSettings(gpol_nrpt || gpol_list);
out:
+ RegCloseKey(key);
return err;
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2144?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib7b9f2994ca828ea699bc6e5b08193dd30965926
Gerrit-Change-Number: 2144
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
