Attention is currently required from: Arne Schwabe, Frank Lichtenheld, Ralf 
Lici, Răzvan Cojocaru.

Lev Stipakov has posted comments on this change by Lev Stipakov. ( 
https://gerrit.openvpn.net/c/openvpn/+/1744?usp=email )

Change subject: probe: Answer probe requests on the server (P_CONTROL_V2)
......................................................................


Patch Set 23:

(1 comment)

File src/openvpn/mudp.c:

https://gerrit.openvpn.net/c/openvpn/+/1744/comment/a5ef98ef_81ca1f39?usp=email 
:
PS20, Line 235:     else if (verdict == VERDICT_VALID_OOB_V1)
> Do we want to also gate the following logic on some option being enabled? 
> This looks like any valid  […]
I don't think we want to gate it. It is not a new exposure - a server without 
tls-auth/crypt will already answer any well-formed RESET_V2 with the HMAC 
cookie over the same path. There is no amplification and server keeps no state 
per probe.



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/1744?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I930d3789e0313aa0c3bc51ee5fd1d108343d59f0
Gerrit-Change-Number: 1744
Gerrit-PatchSet: 23
Gerrit-Owner: Lev Stipakov <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Ralf Lici <[email protected]>
Gerrit-CC: Frank Lichtenheld <[email protected]>
Gerrit-CC: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Ralf Lici <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Frank Lichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 06 Nov 2026 13:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to