Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2119?usp=email
to review the following change.
Change subject: lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()
......................................................................
lladdr: pass S_* flags, not M_WARN, to openvpn_execve_check()
The flags argument takes S_* values. M_WARN shares no bits with them,
so this is no functional change.
Change-Id: Ieee93e625bd25f1f674ce1c3b6475fd73770c73f
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/lladdr.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/19/2119/1
diff --git a/src/openvpn/lladdr.c b/src/openvpn/lladdr.c
index 195245f..554975c 100644
--- a/src/openvpn/lladdr.c
+++ b/src/openvpn/lladdr.c
@@ -36,7 +36,7 @@
struct argv argv = argv_new();
argv_printf(&argv, IFCONFIG_LLADDR_FMT, IFCONFIG_PATH, ifname, lladdr);
argv_msg(M_INFO, &argv);
- int r = openvpn_execve_check(&argv, es, M_WARN, "ERROR: Unable to set link
layer address.");
+ int r = openvpn_execve_check(&argv, es, 0, "ERROR: Unable to set link
layer address.");
argv_free(&argv);
return r;
#else
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2119?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieee93e625bd25f1f674ce1c3b6475fd73770c73f
Gerrit-Change-Number: 2119
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
