Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2124?usp=email
to review the following change.
Change subject: tun: make delete_route_connected_v6_net() and
create_arbitrary_remote() static
......................................................................
tun: make delete_route_connected_v6_net() and create_arbitrary_remote() static
Neither is used outside tun.c or declared in a header.
create_arbitrary_remote() has had no FreeBSD/DragonFly caller since
94db3261 ("FreeBSD: for topology subnet, put tun interface into
IFF_BROADCAST mode"), so limit it to NetBSD and OpenBSD to avoid an
unused static function there.
Change-Id: I766eff47993375c80895755355919ede11b488db
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/tun.c
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/24/2124/1
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 225d8b1..b6728fa 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -988,7 +988,7 @@
add_route_ipv6(&r6, tt, 0, es, NULL);
}
-void
+static void
delete_route_connected_v6_net(const struct tuntap *tt)
{
struct route_ipv6 r6;
@@ -1005,8 +1005,7 @@
#endif /* if defined(_WIN32) || defined(TARGET_DARWIN) ||
defined(TARGET_NETBSD) || \
defined(TARGET_OPENBSD) */
-#if defined(TARGET_FREEBSD) || defined(TARGET_DRAGONFLY) ||
defined(TARGET_NETBSD) \
- || defined(TARGET_OPENBSD)
+#if defined(TARGET_NETBSD) || defined(TARGET_OPENBSD)
/* we can't use true subnet mode on tun on all platforms, as that
* conflicts with IPv6 (wants to use ND then, which we don't do),
* but the OSes want "a remote address that is different from ours"
@@ -1016,7 +1015,7 @@
* is still point to point and no layer 2 resolution is done...
*/
-in_addr_t
+static in_addr_t
create_arbitrary_remote(const struct tuntap *tt)
{
in_addr_t remote;
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I766eff47993375c80895755355919ede11b488db
Gerrit-Change-Number: 2124
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
