Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2120?usp=email
to review the following change.
Change subject: tun: log the actual error in Windows tun_read_queue()
......................................................................
tun: log the actual error in Windows tun_read_queue()
The read error message passed the ReadFile() result, which is always
FALSE on that path, to strerror_win32() instead of GetLastError()'s
err, so it never showed the real error.
Change-Id: I8b9efc75656e01df9afe99c280ba8c9c82e937f0
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/tun.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/20/2120/1
diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 225d8b1..10f738c 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -3305,7 +3305,7 @@
tt->reads.iostate = IOSTATE_IMMEDIATE_RETURN;
tt->reads.status = err;
dmsg(D_WIN32_IO, "WIN32 I/O: TAP Read error [%d] : %s", len,
- strerror_win32(status, &gc));
+ strerror_win32(err, &gc));
gc_free(&gc);
}
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2120?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8b9efc75656e01df9afe99c280ba8c9c82e937f0
Gerrit-Change-Number: 2120
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
