Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to reexamine a change. Please visit
https://gerrit.openvpn.net/c/openvpn/+/2146?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by Arne Schwabe
Change subject: reflect_filter: initialise warning_displayed in the rate limiter
......................................................................
reflect_filter: initialise warning_displayed in the rate limiter
initial_rate_limit_init() allocates with ALLOC_OBJ, which does not
clear, and assigns every field but warning_displayed. The first period
reset assigns it before anything reads it, so nothing misbehaves today,
but there is no reason to leave a field undefined.
Change-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc
Signed-off-by: Lev Stipakov <[email protected]>
---
M src/openvpn/reflect_filter.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/2146/2
diff --git a/src/openvpn/reflect_filter.c b/src/openvpn/reflect_filter.c
index e5226e4..953fff5 100644
--- a/src/openvpn/reflect_filter.c
+++ b/src/openvpn/reflect_filter.c
@@ -95,6 +95,7 @@
irl->period_length = period_length;
irl->curr_period_counter = 0;
irl->last_period_reset = 0;
+ irl->warning_displayed = false;
return irl;
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc
Gerrit-Change-Number: 2146
Gerrit-PatchSet: 2
Gerrit-Owner: Lev Stipakov <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
