Attention is currently required from: Arne Schwabe, Max Fillinger, Răzvan 
Cojocaru.

Steffan Karger has posted comments on this change by Răzvan Cojocaru. ( 
https://gerrit.openvpn.net/c/openvpn/+/2152?usp=email )

Change subject: ssl_verify: reject an empty certificate fingerprint
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
This is a nice minimal fix which can be used for master and the supported 
release branches.

The real issue though seems to be in the underlying set of verify functions 
(return 0-length buffers instead of errors) and the verify list (not specifying 
the hash length), which have interfaces that are just too easy to get wrong. 
I'll put it on my list to refactor those.



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2152?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc9eb15714f14a9f49366fc84072087fc3f013c9
Gerrit-Change-Number: 2152
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Max Fillinger <[email protected]>
Gerrit-Reviewer: Steffan Karger <[email protected]>
Gerrit-CC: Gert Doering <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Max Fillinger <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Tue, 10 Nov 2026 14:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to