Attention is currently required from: Arne Schwabe, Gert Doering. Răzvan Cojocaru has posted comments on this change by Gert Doering. ( https://gerrit.openvpn.net/c/openvpn/+/2170?usp=email )
Change subject: DragonFly: bring things back into a working state ...................................................................... Patch Set 1: Code-Review-1 (5 comments) Patchset: PS1: The `clang-format` filter doesn't pass for this patch. File src/openvpn/tun.c: https://gerrit.openvpn.net/c/openvpn/+/2170/comment/a7bb5511_9bb3d058?usp=email : PS1, Line 2900: * the first free device, ask with devname(3) what you got, and This says "ask with devname" but the code uses `fdevname()`. https://gerrit.openvpn.net/c/openvpn/+/2170/comment/99e687a7_8bbb6dc0?usp=email : PS1, Line 2911: if (strcmp(dev, "tap") == 0 || strcmp(dev, "tun") == 0) `if (!dev_node && (strcmp(dev, "tap") == 0 || strcmp(dev, "tun") == 0))`? https://gerrit.openvpn.net/c/openvpn/+/2170/comment/e529fc41_03291e67?usp=email : PS1, Line 2918: msg(M_FATAL, "Cannot allocate DragonFly TUN/TAP %s dynamically", tunname); Would this be better as `M_ERR` (so we can also get `strerror(errno)`)? https://gerrit.openvpn.net/c/openvpn/+/2170/comment/23ab84c9_9f5e251a?usp=email : PS1, Line 2924: msg(M_FATAL, "Cannot query DragonFly TUN/TAP device name"); Would `M_ERR` fit better here (to get the system error as well)? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5ab959e7101cf801ac93e5185855e75db0fb6225 Gerrit-Change-Number: 2170 Gerrit-PatchSet: 1 Gerrit-Owner: Gert Doering <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Gert Doering <[email protected]> Gerrit-Comment-Date: Wed, 11 Nov 2026 07:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
