Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2171?usp=email
to review the following change.
Change subject: init: free actual_name when replacing the Android tuntap
......................................................................
init: free actual_name when replacing the Android tuntap
With --persist-tun, do_open_tun() frees the old tuntap struct but
not its actual_name, leaking it on every reconnect.
Change-Id: I1295d911c993a02397565e26cece0f0861a2e5f8
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/init.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/71/2171/1
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 3bc4de4..6664a4d 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -1845,6 +1845,7 @@
if (c->c1.tuntap)
{
oldtunfd = c->c1.tuntap->fd;
+ free(c->c1.tuntap->actual_name);
free(c->c1.tuntap);
c->c1.tuntap = NULL;
c->c1.tuntap_owned = false;
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2171?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1295d911c993a02397565e26cece0f0861a2e5f8
Gerrit-Change-Number: 2171
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
