Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Antonio Quartulli has posted comments on this change by Răzvan Cojocaru. ( https://gerrit.openvpn.net/c/openvpn/+/2161?usp=email )
Change subject: openvpnserv: only remove search domains that were added ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: I have a suggestion below in the code. However, the patch is also fine this way, so it gets my +2. I leave to Razvan the decision. File src/openvpnserv/interactive.c: https://gerrit.openvpn.net/c/openvpn/+/2161/comment/86815028_6d75c77a?usp=email : PS1, Line 1826: const BOOL added = AddDnsSearchDomains(list_key, have_list, wide_domains); wouldn't be cleaner (and safer, so we don't risk re-introducing similar bugs) to take the same approach as done below around line 3020? There we first add the item to the list and only then we touch the registry. If AddListItem() fails, we don't need to roll back anything. Does it make sense? This way we also re-use the same coding pattern. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2161?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7ffae4da3b29521844a31d234fe6a9dd08954cf4 Gerrit-Change-Number: 2161 Gerrit-PatchSet: 1 Gerrit-Owner: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: Antonio Quartulli <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Wed, 11 Nov 2026 09:58:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
