Attention is currently required from: Antonio Quartulli, Arne Schwabe.

Răzvan Cojocaru has posted comments on this change by Răzvan Cojocaru. ( 
https://gerrit.openvpn.net/c/openvpn/+/2161?usp=email )

Change subject: openvpnserv: only remove search domains that were added
......................................................................


Patch Set 2:

(1 comment)

File src/openvpnserv/interactive.c:

https://gerrit.openvpn.net/c/openvpn/+/2161/comment/cf8087ab_032b3022?usp=email 
:
PS1, Line 1826:         const BOOL added = AddDnsSearchDomains(list_key, 
have_list, wide_domains);
> wouldn't be cleaner (and safer, so we don't risk re-introducing similar bugs) 
> to take the same appro […]
Makes sense, done. Thanks!



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2161?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7ffae4da3b29521844a31d234fe6a9dd08954cf4
Gerrit-Change-Number: 2161
Gerrit-PatchSet: 2
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Antonio Quartulli <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Antonio Quartulli <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Wed, 11 Nov 2026 10:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Antonio Quartulli <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to