Attention is currently required from: Arne Schwabe.

Răzvan Cojocaru has posted comments on this change by Arne Schwabe. ( 
https://gerrit.openvpn.net/c/openvpn/+/2175?usp=email )

Change subject: Extract tls_pre_decrypt_extract_session_id and 
pre_decrypt_find_session
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

File src/openvpn/ssl.c:

https://gerrit.openvpn.net/c/openvpn/+/2175/comment/d00ea4e1_f6613a14?usp=email 
:
PS3, Line 3769: tls_pre_decrypt_extract_session_id(const struct 
link_socket_actual *from,
Should this function also have a Doxygen block?


https://gerrit.openvpn.net/c/openvpn/+/2175/comment/9a6c6ddd_3683b8e8?usp=email 
:
PS3, Line 3792: pre_decrypt_find_session(struct tls_multi *multi, const struct 
link_socket_actual *from,
Should this function also have a `tls_` prefix (like the one above)?



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2175?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I230b3b2483e15477b179b277dc8f7c91c53fa0c0
Gerrit-Change-Number: 2175
Gerrit-PatchSet: 3
Gerrit-Owner: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Wed, 11 Nov 2026 13:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to