Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2176?usp=email
to review the following change.
Change subject: tun: Make error_flags unsigned consistently
......................................................................
tun: Make error_flags unsigned consistently
Previously both int and unsigned int was used.
Change-Id: Ie7228ee95c2b43f9be2bf4c6a9a959af2f729088
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/init.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/2176/1
diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 0bb5390..a92967e 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -1835,7 +1835,7 @@
static bool
-do_open_tun(struct context *c, int *error_flags)
+do_open_tun(struct context *c, unsigned int *error_flags)
{
struct gc_arena gc = gc_new();
bool ret = false;
@@ -2337,7 +2337,7 @@
bool
do_up(struct context *c, bool pulled_options, uint64_t option_types_found)
{
- int error_flags = 0;
+ unsigned int error_flags = 0;
if (!c->c2.do_up_ran)
{
reset_coarse_timers(c);
@@ -2496,7 +2496,7 @@
do_close_tun(c, true);
management_sleep(1);
- int error_flags = 0;
+ unsigned int error_flags = 0;
c->c2.did_open_tun = do_open_tun(c, &error_flags);
update_time();
@@ -4663,7 +4663,7 @@
* open tun/tap device, ifconfig, run up script, etc. */
if (!(options->up_delay || PULL_DEFINED(options)) && (c->mode == CM_P2P ||
c->mode == CM_TOP))
{
- int error_flags = 0;
+ unsigned int error_flags = 0;
c->c2.did_open_tun = do_open_tun(c, &error_flags);
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2176?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie7228ee95c2b43f9be2bf4c6a9a959af2f729088
Gerrit-Change-Number: 2176
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
