Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2178?usp=email
to review the following change.
Change subject: xkey_digest: free the EVP_MD when EVP_Digest() fails
......................................................................
xkey_digest: free the EVP_MD when EVP_Digest() fails
The error path returned without EVP_MD_free().
Change-Id: Ie87632ae3503f4c74b327186e6952f66ada66640
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/xkey_helper.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/78/2178/1
diff --git a/src/openvpn/xkey_helper.c b/src/openvpn/xkey_helper.c
index 6908cbb..fb088a8 100644
--- a/src/openvpn/xkey_helper.c
+++ b/src/openvpn/xkey_helper.c
@@ -71,12 +71,13 @@
}
unsigned int len = (unsigned int)*buflen;
- if (EVP_Digest(src, srclen, buf, &len, md, NULL) != 1)
+ int ret = EVP_Digest(src, srclen, buf, &len, md, NULL);
+ EVP_MD_free(md);
+ if (ret != 1)
{
msg(M_WARN, "WARN: xkey_digest: EVP_Digest failed");
return 0;
}
- EVP_MD_free(md);
*buflen = len;
return 1;
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2178?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie87632ae3503f4c74b327186e6952f66ada66640
Gerrit-Change-Number: 2178
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
