Yeah, whatever. I am not overly fond of all these consts being added
everywhere - they make it harder to parse things "with just one glance",
and they make cross-branch maintenance annoying. Unlike the integer
patch series, we haven't actually found a real bug that way either yet.
The get_default_gateway() changes turn ugly BSD sockaddr_* code into
ugly different BSD sockaddr_* code with more const sprinkled in, so it's
not really making it worse than before, just different...
It passes tests and Frank scrutiny. So be it.
Your patch has been applied to the master branch.
commit f6f035bca56e3b7da845f6e08c7b8bff6bfa97e8
Author: Arne Schwabe
Date: Wed Nov 11 16:21:07 2026 +0100
Silence remaining cppcheck warnings on macOS and FreeBSD
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Frank Lichtenheld <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2108
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg41164.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
