Very reasonable change - two functions with side effects shouldn't be
short-circuited in a condition leading to "not very clearly specified
cleanup in case either one fails". I'm not sure how likely the described
error scenario is, but if it hits, it will mess up user's DNS, so "bug,
fix goes to 2.7".
Only test compiled the 2.7 backport...
Your patch has been applied to the master and release/2.7 branch.
commit 09c4f4a189c989fe6aa9ba59237b3440d4619af9 (master)
commit f5491bc05ea8f0614470d64843dc3c83b6e188f1 (release/2.7)
Author: Razvan Cojocaru
Date: Thu Nov 12 07:32:26 2026 +0100
openvpnserv: only remove search domains that were added
Signed-off-by: Razvan Cojocaru <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
Acked-by: Heiko Hund <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2161
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg41181.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
