Since this survived the BB t_server patch (which uses pools, and t_clients
that verify that they receive the same pool address every time) I guess
it didn't break any of the maths :-)
Interesting code evolution, though, having these nice helper functions
and then never using them...
On the (uint32_t) casts, we had a parallel discussion on IRC, and my
preference is clearly "the mininum amount of extra language elements
that are needed to make the compiler happy *and* enlighten the reader".
Since this is "code cleanup" and is not fixing anything user visible, no
need to go into 2.7
Your patch has been applied to the master branch.
commit 42b615c088c844180c4f5878ec7f0d6cd3e781fb
Author: Razvan Cojocaru
Date: Sat Nov 14 23:15:43 2026 +0100
pool: reuse handle-to-address helpers in ifconfig_pool_acquire()
Signed-off-by: Razvan Cojocaru <[email protected]>
Acked-by: Antonio Quartulli <[email protected]>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2126
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg41340.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel