Attention is currently required from: Arne Schwabe.

Hello Arne Schwabe,

I'd like you to do a code review.
Please visit

    https://gerrit.openvpn.net/c/openvpn/+/2190?usp=email

to review the following change.


Change subject: crypto: drop redundant epoch assignments
......................................................................

crypto: drop redundant epoch assignments

init_key_ctx() already sets ctx->epoch from the key parameters.

Change-Id: I604fdff9c0a7cbbddfd025a72e6f19a96bb51753
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/crypto.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/2190/1

diff --git a/src/openvpn/crypto.c b/src/openvpn/crypto.c
index db1cb41..dda6702 100644
--- a/src/openvpn/crypto.c
+++ b/src/openvpn/crypto.c
@@ -1040,7 +1040,6 @@
     snprintf(log_prefix, sizeof(log_prefix), "Outgoing %s", name);
     init_key_ctx(ctx, key_params, kt, OPENVPN_OP_ENCRYPT, log_prefix);
     key_ctx_update_implicit_iv(ctx, key_params);
-    ctx->epoch = key_params->epoch;
 }

 void
@@ -1052,7 +1051,6 @@
     snprintf(log_prefix, sizeof(log_prefix), "Incoming %s", name);
     init_key_ctx(ctx, key_params, kt, OPENVPN_OP_DECRYPT, log_prefix);
     key_ctx_update_implicit_iv(ctx, key_params);
-    ctx->epoch = key_params->epoch;
 }

 void

--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2190?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I604fdff9c0a7cbbddfd025a72e6f19a96bb51753
Gerrit-Change-Number: 2190
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to