Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2191?usp=email
to review the following change.
Change subject: ssl_verify: remove --client-crresponse temp file
......................................................................
ssl_verify: remove --client-crresponse temp file
The file holding the client's challenge response was never deleted,
although the manual says it is removed after the script returns.
Unlink it on every exit path.
Change-Id: Ifbd6badab31a48653fa0bca7f086db058f83f891
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/ssl_verify.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/2191/1
diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c
index 8641d15..6792d91 100644
--- a/src/openvpn/ssl_verify.c
+++ b/src/openvpn/ssl_verify.c
@@ -1487,6 +1487,10 @@
tls_deauthenticate(multi);
}
done:
+ if (tmp_file)
+ {
+ platform_unlink(tmp_file);
+ }
argv_free(&argv);
gc_free(&gc);
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd6badab31a48653fa0bca7f086db058f83f891
Gerrit-Change-Number: 2191
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel