Attention is currently required from: Arne Schwabe. Ralf Lici has posted comments on this change by Ralf Lici. ( https://gerrit.openvpn.net/c/openvpn/+/1531?usp=email )
Change subject: management: resync timer on bytecount interval change ...................................................................... Patch Set 1: (1 comment) File src/openvpn/manage.c: https://gerrit.openvpn.net/c/openvpn/+/1531/comment/c5ca2000_1a51c973?usp=email : PS1, Line 494: if (man->persist.callback.arg) > All the other uses of man->persist.callback.arg seem to just use that without > check. […] Sorry, I completely missed this comment. The check is necessary because this function can run before `init_management_callback_multi`/`init_management_callback_p2p` has populated the `persist.callback.arg` field, specifically when `--management-hold` is set. In that case, the management interface will still process commands while waiting for the release and removing the guard will lead to null deref. Other man functions do not need that protection because they check the callback presence itself (for example `man_status`), operate on management state (for example `hold` or `env-filter`) or have other invariants making the `arg` check unnecessary. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/1531?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: Ibea20c0f2c3df9f1f6509d662ab2b5fb4ce5e18d Gerrit-Change-Number: 1531 Gerrit-PatchSet: 1 Gerrit-Owner: Ralf Lici <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Mon, 16 Nov 2026 13:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arne Schwabe <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
