Gert Doering has uploaded a new patch set (#2) to the change originally created by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2193?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by Răzvan Cojocaru Change subject: GHA: Disable -Werror for MinGW 32bit ...................................................................... GHA: Disable -Werror for MinGW 32bit There are some build failures related to -Wsign-conversion now that look like clear bugs in MinGW. Since we do not plan to support 32bit Windows going forward, let's not worry too much about compiler warnings anymore. We will still detect if we break the build completely, for now. While investigating the issue, remove a wrong comment. With -Wsign-conversion, all builds need the casts. Change-Id: I6079f454e5bb1ce7c4ecc5343ce2231c417ca879 Signed-off-by: Frank Lichtenheld <[email protected]> Acked-by: Razvan Cojocaru <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2193 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg41439.html Signed-off-by: Gert Doering <[email protected]> --- M .github/workflows/build.yaml M src/openvpn/auth_token.c 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/93/2193/2 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 27f08df..d50b7ff 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -81,6 +81,10 @@ arch: [x86, x64] build: [Release, Debug] + include: + - arch: x86 + configure-args: "['-DUSE_WERROR=OFF']" + name: "gcc-mingw - ${{ matrix.arch }} - ${{ matrix.build }} - OSSL" runs-on: ubuntu-26.04 env: @@ -113,6 +117,7 @@ uses: lukka/run-cmake@5d55ea7949e25f69f0ecb516d8d572297e03a956 # v10.9 with: configurePreset: mingw-${{ matrix.arch }} + configurePresetAdditionalArgs: ${{ matrix.configure-args }} buildPreset: mingw-${{ matrix.arch }} buildPresetAdditionalArgs: "['--config ${{ matrix.build }}']" diff --git a/src/openvpn/auth_token.c b/src/openvpn/auth_token.c index 703a0b2..261c7c2 100644 --- a/src/openvpn/auth_token.c +++ b/src/openvpn/auth_token.c @@ -364,7 +364,6 @@ /* Accept session tokens only if their timestamp is in the acceptable range * for renegotiations. - * Cast is required for systems with 32bit time_t, e.g. Windows x86. */ const time_t token_reneg_deadline = (time_t)timestamp + 2 * session->opt->auth_token_renewal; bool in_renegotiation_time = now >= (time_t)timestamp && now < token_reneg_deadline; -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6079f454e5bb1ce7c4ecc5343ce2231c417ca879 Gerrit-Change-Number: 2193 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
