Attention is currently required from: Arne Schwabe, Frank Lichtenheld.

Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( 
https://gerrit.openvpn.net/c/openvpn/+/2198?usp=email )

Change subject: buffer: Switch buf_forward_capacity and buf_write_set to size_t
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.openvpn.net/c/openvpn/+/2198/comment/20db7c65_846f6381?usp=email 
:
PS1, Line 7: buffer: Switch buf_forward_capacity and buf_write_set to size_t
The function name is buf_set_write().


File src/openvpn/ssl_ncp.c:

https://gerrit.openvpn.net/c/openvpn/+/2198/comment/b9962930_56ddd144?usp=email 
:
PS1, Line 566:     ASSERT(ncp_ciphers_len <= INT_MAX);
Do we still need the `ASSERT()` if we are no longer casting to `int`?



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2198?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9c2403c21ef8f21a0fbd998346c8ad719b4b9972
Gerrit-Change-Number: 2198
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Frank Lichtenheld <[email protected]>
Gerrit-Comment-Date: Mon, 16 Nov 2026 14:58:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to