Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2200?usp=email )
Change subject: manage: Switch all sleep methods to unsigned ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/manage.c: https://gerrit.openvpn.net/c/openvpn/+/2200/comment/483c9bdd_d3255c8c?usp=email : PS1, Line 3636: This can now just merge into the declaration, to become `time_t expire = now + sec;` above. https://gerrit.openvpn.net/c/openvpn/+/2200/comment/f4e6d997_2232108c?usp=email : PS1, Line 3657: } while (expire && expire > now); `expire` now can never be `0` (because of `now`), so it can be dropped here. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I34dd7d46c9bc15e32f233741c525759715bb847c Gerrit-Change-Number: 2200 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 16 Nov 2026 15:12:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
