Attention is currently required from: Arne Schwabe.

Hello Arne Schwabe,

I'd like you to do a code review.
Please visit

    https://gerrit.openvpn.net/c/openvpn/+/2201?usp=email

to review the following change.


Change subject: dco: always print the status block
......................................................................

dco: always print the status block

When DCO is enabled print_status() bails out if dco_get_peer_stats()
fails, without writing anything. On a client this happens during the
whole reconnect after a ping-restart, since there's no DCO interface,
so the management "status" command never gets an answer, not even
"END", and the --status file isn't updated either.

Print the status anyway. On a real DCO error SIGUSR1 is still raised
by dco_get_peer_stats(), so the session restart keeps working.

GitHub: closes OpenVPN/openvpn#1146
Change-Id: I831224f06e2f35bfcc9d0fec7d8edfc344c59406
Signed-off-by: Tommaso Bailetti <[email protected]>
---
M src/openvpn/sig.c
1 file changed, 1 insertion(+), 4 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/01/2201/1

diff --git a/src/openvpn/sig.c b/src/openvpn/sig.c
index 0cdb01a..8ea756c 100644
--- a/src/openvpn/sig.c
+++ b/src/openvpn/sig.c
@@ -483,10 +483,7 @@

     if (dco_enabled(&c->options))
     {
-        if (dco_get_peer_stats(c, true) < 0)
-        {
-            return;
-        }
+        dco_get_peer_stats(c, true);
     }

     status_printf(so, "OpenVPN STATISTICS");

--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2201?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I831224f06e2f35bfcc9d0fec7d8edfc344c59406
Gerrit-Change-Number: 2201
Gerrit-PatchSet: 1
Gerrit-Owner: Tommaso Bailetti <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
  • [Openvpn-devel] [XS] Cha... Tommaso Bailetti (Code Review) via Openvpn-devel

Reply via email to