Attention is currently required from: Arne Schwabe, Răzvan Cojocaru.

Antonio Quartulli has posted comments on this change by Răzvan Cojocaru. ( 
https://gerrit.openvpn.net/c/openvpn/+/2208?usp=email )

Change subject: clinat: locate the TCP/UDP header via the IP header length
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

Patchset:

PS1:
yick, been there since 2012!
FTR when the UDP port or the TCP flags/seqnum/acknum/source port was modified, 
the checksum was still properly computed and the packet was *delivered*. which 
makes this a bit more impactful than what the commit says. Definitely worth 
backporting.

@[email protected] dhcp_extract_router_msg() still assumes a 20-byte IP 
header, maybe you want to create another patch for that? 😎



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2208?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibd316e5c3e6a0fb600ec4817aa079554464fd942
Gerrit-Change-Number: 2208
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Antonio Quartulli <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Tue, 17 Nov 2026 08:56:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to