Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Aravind O R has posted comments on this change by Aravind O R. ( https://gerrit.openvpn.net/c/openvpn/+/2213?usp=email )
Change subject: configure: add compiler and linker hardening flags ...................................................................... Patch Set 1: This is the autotools half of adding GCC/clang hardening flags, along the lines of what the MSVC build already does with /sdl, /guard:cf and /CETCOMPAT (2612125d). If the approach is acceptable, the CMake build (used for mingw and development builds) follows in a separate change. Three points where I would like your opinion: 1. It is on by default, with --disable-hardening to turn it off. A flag set in CFLAGS or LDFLAGS still wins, for example -fno-stack-protector or -Wl,-z,lazy as OpenWrt and Buildroot use. If you prefer opt-in, that is a one-word change. 2. -fcf-protection=full only marks the binaries as IBT/SHSTK compatible. Linux enforces shadow stacks only where the kernel and glibc enable them. It is cheap and matches what distributions ship, but I can drop it. 3. I wrote a small macro instead of importing AX_CHECK_LINK_FLAG and AX_ADD_FORTIFY_SOURCE from autoconf-archive, because the probe has to treat linker warnings as failures and must not override a FORTIFY level chosen elsewhere. Happy to switch to the archive macros if you prefer them. The testing is summarised in the commit message. I only had x86_64 Linux, so the buildbot results for the BSDs, macOS (arm64 with -mbranch-protection) and Solaris will be the first real check there. I can share the container build logs (patched against master, with the ELF checks of each binary) if they are useful. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8fe2cbeadde3bad2185c4cee824ed2fe307e29e2 Gerrit-Change-Number: 2213 Gerrit-PatchSet: 1 Gerrit-Owner: Aravind O R <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 17 Nov 2026 16:42:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
