Gert Doering has uploaded a new patch set (#3) to the change originally created by Răzvan Cojocaru. ( https://gerrit.openvpn.net/c/openvpn/+/2202?usp=email )
The following approvals got outdated and were removed: Code-Review+2 by Arne Schwabe, Code-Review+2 by Frank Lichtenheld Change subject: mudp: drop unused addr parameter of do_pre_decrypt_check() ...................................................................... mudp: drop unused addr parameter of do_pre_decrypt_check() It was passed by value on every connection attempt and never read. Change-Id: I388a52d19633d0604a1610fbfba31cfff7f518ef Signed-off-by: Razvan Cojocaru <[email protected]> Acked-by: Arne Schwabe <[email protected]> Acked-by: Frank Lichtenheld <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg41526.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/mudp.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/2202/3 diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index 217b299..0e1e21d 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -113,7 +113,7 @@ /** Returns a verdict if this packet should create a new session */ static enum pre_decrypt_verdict do_pre_decrypt_check(struct multi_context *m, struct tls_pre_decrypt_state *state, - struct mroute_addr addr, struct link_socket *sock) + struct link_socket *sock) { ASSERT(m->top.c2.tls_auth_standalone); @@ -259,7 +259,7 @@ struct tls_pre_decrypt_state state = { 0 }; struct multi_instance *mi = NULL; - enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, *real, sock); + enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, sock); if (verdict != PRE_DECRYPT_NO_ACTION) { -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I388a52d19633d0604a1610fbfba31cfff7f518ef Gerrit-Change-Number: 2202 Gerrit-PatchSet: 3 Gerrit-Owner: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
