Attention is currently required from: Arne Schwabe, Gianmarco De Gregori.

Gert Doering has posted comments on this change by Gianmarco De Gregori. ( 
https://gerrit.openvpn.net/c/openvpn/+/2211?usp=email )

Change subject: multi: raise the open files limit for --max-clients
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File src/openvpn/multi.c:

https://gerrit.openvpn.net/c/openvpn/+/2211/comment/3b5947bd_b36b1497?usp=email 
:
PS2, Line 319:     }
this should print an error message if it does not work - I tried this (Gentoo, 
setting `ulimit -n 30` beforehand) and what I got in the log was
```
2026-11-17 19:10:40 us=71040 WARNING: the open files limit (30) is too low for 
--max-clients 1024, TCP clients may be refused before --max-clients is reached
```
but no indication that it actually tried to raise it, and bumped into some 
error (which is surprising since it should have had root privs...)

with default shell settings increasing *did* work
```
2026-11-17 19:14:24 us=888551 Raised the open files limit from 1024 to 1088
```
(maybe add a NOTE: here?)



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2211?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I17fafbe65fd3ff510a72ed809c85b0d19343fad2
Gerrit-Change-Number: 2211
Gerrit-PatchSet: 2
Gerrit-Owner: Gianmarco De Gregori <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Gert Doering <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Gianmarco De Gregori <[email protected]>
Gerrit-Comment-Date: Tue, 17 Nov 2026 18:15:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to