Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to reexamine a change. Please visit
https://gerrit.openvpn.net/c/openvpn/+/2191?usp=email
to look at the new patch set (#3).
Change subject: ssl_verify: remove script temp files on all exit paths
......................................................................
ssl_verify: remove script temp files on all exit paths
The file holding the client's challenge response was never deleted,
although the manual says it is removed after the script returns. The
--auth-user-pass-verify via-file credentials file was kept when the
deferred auth control files could not be created. Unlink both on every
exit path.
Change-Id: Ifbd6badab31a48653fa0bca7f086db058f83f891
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/ssl_verify.c
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/91/2191/3
diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c
index 8641d15..75cda97 100644
--- a/src/openvpn/ssl_verify.c
+++ b/src/openvpn/ssl_verify.c
@@ -1372,7 +1372,7 @@
"could not create deferred auth control file",
__func__);
retval = OPENVPN_PLUGIN_FUNC_ERROR;
- goto error;
+ goto done;
}
/* call command */
@@ -1415,7 +1415,6 @@
platform_unlink(tmp_file);
}
-error:
if (!session->opt->auth_user_pass_verify_script_via_file)
{
setenv_del(session->opt->es, "password");
@@ -1487,6 +1486,10 @@
tls_deauthenticate(multi);
}
done:
+ if (tmp_file)
+ {
+ platform_unlink(tmp_file);
+ }
argv_free(&argv);
gc_free(&gc);
}
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2191?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd6badab31a48653fa0bca7f086db058f83f891
Gerrit-Change-Number: 2191
Gerrit-PatchSet: 3
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel