Attention is currently required from: Arne Schwabe.
Hello Arne Schwabe,
I'd like you to do a code review.
Please visit
https://gerrit.openvpn.net/c/openvpn/+/2218?usp=email
to review the following change.
Change subject: occ: apply the --mtu-test size steps again
......................................................................
occ: apply the --mtu-test size steps again
Since fb76954a, check_send_occ_load_test_dowork() ignores the delta of
each mtu_load_test_sequence entry, so every probe has the full size.
When those are dropped, the test reports the size of the largest other
packet instead of the largest probe that got through. Add the delta
back.
Change-Id: I399411e328c7d4db4d2033500cafc0479ef0d65f
Signed-off-by: Razvan Cojocaru <[email protected]>
---
M src/openvpn/occ.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/2218/1
diff --git a/src/openvpn/occ.c b/src/openvpn/occ.c
index 38685f5..86b3a83 100644
--- a/src/openvpn/occ.c
+++ b/src/openvpn/occ.c
@@ -202,7 +202,7 @@
size_t header_size =
frame_calculate_protocol_header_size(&c->c1.ks.key_type,
&c->options, false);
- c->c2.occ_mtu_load_size = payload_size + header_size;
+ c->c2.occ_mtu_load_size = (int)(payload_size + header_size) +
entry->delta;
}
else
{
--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2218?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I399411e328c7d4db4d2033500cafc0479ef0d65f
Gerrit-Change-Number: 2218
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel