Attention is currently required from: Arne Schwabe, Răzvan Cojocaru.

Frank Lichtenheld has posted comments on this change by Răzvan Cojocaru. ( 
https://gerrit.openvpn.net/c/openvpn/+/2215?usp=email )

Change subject: socket_util: check the address family in addrlist_match()
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/openvpn/socket_util.h:

https://gerrit.openvpn.net/c/openvpn/+/2215/comment/0cb3e10c_e12ae1b5?usp=email 
:
PS1, Line 315:         switch (a1->addr.sa.sa_family)
Would look much nicer like this?

```suggestion
        if (a1->addr.sa.sa_family != curele->ai_family)
        {
           continue;
        }
        switch (a1->addr.sa.sa_family)
```



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2215?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic3efcdb7bc4e60a81b9292adfe7f8e22b86e274a
Gerrit-Change-Number: 2215
Gerrit-PatchSet: 1
Gerrit-Owner: Răzvan Cojocaru <[email protected]>
Gerrit-Reviewer: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Frank Lichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Răzvan Cojocaru <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Comment-Date: Wed, 18 Nov 2026 14:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to