Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Răzvan Cojocaru. ( https://gerrit.openvpn.net/c/openvpn/+/2209?usp=email )
Change subject: dhcp: locate the UDP header via the IP header length ...................................................................... Patch Set 1: (1 comment) File src/openvpn/dhcp.c: https://gerrit.openvpn.net/c/openvpn/+/2209/comment/1ad2e11d_e400ab5f?usp=email : PS1, Line 160: const struct openvpn_iphdr *ip = (const struct openvpn_iphdr *)BPTR(ipbuf); > Are there potential issues with unaligned access here? No. The structs are all `#pragma pack(1)`, so member accesses are unaligned-safe. The UDP offset (IHL * 4) also keeps the old 20-byte offset's alignment. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3630ac3defbb64e252ac3009fdd784153367e4fd Gerrit-Change-Number: 2209 Gerrit-PatchSet: 1 Gerrit-Owner: Răzvan Cojocaru <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-CC: Frank Lichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 18 Nov 2026 16:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frank Lichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
