On Wed, May 25, 2016 at 4:04 AM, Selva Nair <selva.n...@gmail.com> wrote:
> This looks like a very useful feature that I went ahead and took a stab at
> it.  See PR #50 at
> https://github.com/OpenVPN/openvpn/pull/50
>

Thank you very much for implementing this feature! That's exactly what
I had in mind when I sent my request to the list.

> It has undergone very limited testing, so may still have some wrinkles ---
> options processing in OpenVPN is not something I fully understand. Hence the
> PR and not a patch. Feedback most welcome.
>

I suggest to split the "option string" in two separate parts:

Usage: --pull-filter accept|reject "option string"

to

Usage: --pull-filter accept|reject "option" "option-filter"

where "option" is an exact match (identical string) for the
corresponding openvpn option and "option-filter" is a partial match.

As you wrote having things like 'Note the space at the end of "route "
to not reject "route-gateway"' is error prone. Users might complain
about hard-to-explain config errors. Or even worse, one filter may
work for openvpn version X and not for version Y because it matches a
different scope of openvpn options.

Chris

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
_______________________________________________
Openvpn-users mailing list
Openvpn-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-users

Reply via email to