you may also try the myfaces coding style.

please see the patch.

LieGrue,
strub
----------------------------------------------------------------
“Multiple exclamation marks are a sure sign of a diseased mind!” 
(Sir Terry Pratchett)


--- Gurkan Erdogdu <[email protected]> schrieb am Do, 8.1.2009:

> Von: Gurkan Erdogdu <[email protected]>
> Betreff: Re: tabs in sources
> An: [email protected]
> Datum: Donnerstag, 8. Januar 2009, 22:04
> :) I looked at the MVN book  assembly chapter from the
> internet 
> 
> :/Gurkan
> 
> 
> 
> 
> ________________________________
> From: Mark Struberg <[email protected]>
> To: [email protected]
> Sent: Thursday, January 8, 2009 11:00:49 PM
> Subject: Re: tabs in sources
> 
> btw, I looked at the distribution module now
> 
> mvn package -Ddistribute=true
> 
> behaves a bit weird.
> 
> It tries to download the artifacts we do like to build from
> the public maven repo first and therefore fails.
> Did you copy this from somewhere?
> 
> Maybe I didn't get the point... 
> 
> LieGrue,
> strub
> ----------------------------------------------------------------
> “Multiple exclamation marks are a sure sign of a diseased
> mind!” 
> (Sir Terry Pratchett)
> 
> 
> --- Mark Struberg <[email protected]> schrieb am Do,
> 8.1.2009:
> 
> > Von: Mark Struberg <[email protected]>
> > Betreff: Re: tabs in sources
> > An: [email protected]
> > Datum: Donnerstag, 8. Januar 2009, 21:55
> > simply do a
> > 
> > mvn clean site
> > 
> > in the webbeans-impl after you applied the patch with
> the
> > reporting sectionn.
> > 
> > lg,
> > strub
> > 
> > --- Gurkan Erdogdu <[email protected]>
> schrieb
> > am Do, 8.1.2009:
> > > Von: Gurkan Erdogdu
> <[email protected]>
> > > Betreff: Re: tabs in sources
> > > An: [email protected]
> > > Datum: Donnerstag, 8. Januar 2009, 21:51
> > > Mark how to create reports? which mvn command
> that
> > pushes
> > > the reports?
> > > 
> > > Thanks;
> > > 
> > > /Gurkan
> > > 
> > > 
> > > 
> > > 
> > > ________________________________
> > > From: Mark Struberg <[email protected]>
> > > To: [email protected]
> > > Sent: Thursday, January 8, 2009 9:25:57 PM
> > > Subject: Re: tabs in sources
> > > 
> > > Thanks for seconding this, Kevan ;)
> > > 
> > > I personally would prefer using an already
> established
> > > coding/checkstyle ruleset like maven or myfaces
> > instead of
> > > having our own one. I think myfaces_checks comes
> very
> > close
> > > if we drop the tabs in favour to spaces.
> > > 
> > > Btw, I looked at the test coverage yesterday, and
> the
> > > result wasn't that bad. It's actually
> really
> > good
> > > compared to a lot of commercial projects I've
> seen
> > the
> > > last 2 decades ;)
> > > 
> > > 
> > > LieGrue,
> > > strub
> > >
> >
> ----------------------------------------------------------------
> > > “Multiple exclamation marks are a sure sign of
> a
> > diseased
> > > mind!” 
> > > (Sir Terry Pratchett)
> > > 
> > > 
> > > --- Kevan Miller <[email protected]>
> > schrieb am
> > > Do, 8.1.2009:
> > > 
> > > > Von: Kevan Miller
> <[email protected]>
> > > > Betreff: Re: tabs in sources
> > > > An: [email protected]
> > > > Datum: Donnerstag, 8. Januar 2009, 18:31
> > > > On Jan 8, 2009, at 10:14 AM, Mark Struberg
> wrote:
> > > > 
> > > > > Hi!
> > > > > 
> > > > > I know this is a highly
> > 'unproductive'
> > > and
> > > > unwelcome task from a developers
> perspective, so
> > > don't
> > > > slap me - a simple yes or no is enough ;)
> > > > > 
> > > > > What do you think about removing all
> tabs
> > from
> > > the
> > > > sources and only use spaces?
> > > > > 
> > > > > I know this would mean to do a complete
> code
> > > > reformatting but tabs are a big mess and are
> > going to
> > > get
> > > > screwed up often. And now may be the last
> > possible
> > > moment
> > > > for such things.
> > > > > 
> > > > > Don't be rude to me, it was only a
> > question
> > > ;)
> > > > 
> > > > :) Can't see anybody being too upset...
> I
> > agree...
> > > I
> > > > hate tab characters in source code. All
> IDE's
> > and
> > > > editors that I know of can be easily
> configured
> > to
> > > replace
> > > > tabs with spaces.
> > > > 
> > > > This should probably be part of a
> OpenWebBeans
> > coding
> > > > conventions/guidelines.
> > > > 
> > > > --kevan


      

Reply via email to