Hi Mark; Looks very good!. Some thoughts : It seems from the patch that SPI interface codes are under the *webbeans-impl* module. Can we create another module (webbeans-spi) and put SPI interface codes and SPI specific util classes into it?
WDYT? In the mean time, I have branched the M1 version. So, you could commit to the code into the trunk after running the tests successfully. Thanks; ________________________________ From: Mark Struberg (JIRA) <[email protected]> To: [email protected] Sent: Thursday, February 5, 2009 11:24:59 PM Subject: [jira] Updated: (OWB-75) create SPI integration support [ https://issues.apache.org/jira/browse/OWB-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Struberg updated OWB-75: ----------------------------- Attachment: OWB-75.patch please review this patch, so I can commit it after M1 is released > create SPI integration support > ------------------------------ > > Key: OWB-75 > URL: https://issues.apache.org/jira/browse/OWB-75 > Project: OpenWebBeans > Issue Type: New Feature > Reporter: Mark Struberg > Assignee: Mark Struberg > Attachments: OWB-75.patch > > > All Resources/Utilities which are depending on a specific environment must > only be accessed via services which are provided via a Service Provider > Interface. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
