Hi Mark;

>>>>tw, I have no clue how we should implement Manager#setCurrent, any 
>>>>suggestions?

I understand from the spec is that, we have to register context related with 
the given scope with the current (this) activity. Whenever we get the Manager 
instance, we have to find the current activity. 

I have implemented the setCurrentMethod. Please see the ActivityManager class 
how to get/set the current activity.

>>>>Another thing which I was not sure: A bunch of TCK tests fail due to the 
>>>>fact that DependingContext is not active for them! 

Which tests that are failed! When I was running the TCK, I have excluded the 
some tests that are not implemented yet in the OWB, like enterprise, jms, etc.


>>>>>Have we forgotten this, or was this intentionally?
Intentional. Because, dependent context is activated based on some conditions. 
You can see try--finally blocks in the code that are related with activating 
and passivating the dependent context.




________________________________
From: Mark Struberg <[email protected]>
To: [email protected]
Sent: Wednesday, April 22, 2009 7:24:15 PM
Subject: ChildActivityManager


Hiho!

Today I tried to implement section 11.6 of the Spec by introducing a 
ChildActivityManager. Please read the JavaDocs and tell me if it is not clear 
enough.

Please review my changes, maybe you have a better idea how this may be 
implemented?
There are a lot of open //X TODO in the code. Basically all things which needs 
to be reviewed ;)

Btw, I have no clue how we should implement Manager#setCurrent, any suggestions?


Another thing which I was not sure: A bunch of TCK tests fail due to the fact 
that DependingContext is not active for them! 

For the TCKs we have the 
org.apache.webbeans.test.tck.ManagersImpl#getManager()
where something like         ContextFactory.initApplicationContext(null);
is being called for all other default contexts but not for DependingContext. 
Have we forgotten this, or was this intentionally?

LieGrue,
strub


      

Reply via email to