Oki, if it turns out to be reusable, we can still slice it into an own module later on.
LieGrue, strub --- Gurkan Erdogdu <[email protected]> schrieb am Fr, 19.6.2009: > Von: Gurkan Erdogdu <[email protected]> > Betreff: Re: svn commit: r786229 - in > /incubator/openwebbeans/trunk/webbeans-geronimo: ./ > src/main/java/org/apache/webbeans/spi/ee/openejb/ > src/main/java/org/apache/webbeans/spi/ee/openejb/ejb/ > src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/ src/test/ja > An: [email protected] > Datum: Freitag, 19. Juni 2009, 13:00 > Hi Mark, > > Thanks for giving your concerns. > > I put *ejb* package here because EJB integration will be > very specific to an > application server. I think that it is very hard to > write *generic spi* for > ejb that we can implement for multiple containers. > > Thanks; > > --Gurkan > > > 2009/6/19 Mark Struberg <[email protected]> > > > > > Hi Gurkan! > > > > The webbeans-geronimo package is a bit of a > compromise. > > > > The whole geronimo integration should really been done > on the geronimo > > side, but it is simply too early and would cause too > much effort now for > > this step. So I started this package here to have all > in one place so we can > > test and get it stable and later hand it over to the > geronimo guys. > > > > The reason why I don't think this module should stay > there is geronimos > > lifecycle. This is a chicken egg problem with > dependencies. Clearly geronimo > > uses us and we use openejb. So we may have different > branches for different > > openejb versions to integrate. But the integration > into geronimo should > > finally been done on the geronimo side imho. > > > > I write this, so all have a common understanding what > this module was > > originally intended for. > > > > lieGrue, > > strub > > > > --- [email protected] > <[email protected]> > schrieb am Do, 18.6.2009: > > > > > Von: [email protected] > <[email protected]> > > > Betreff: svn commit: r786229 - in > > /incubator/openwebbeans/trunk/webbeans-geronimo: ./ > > src/main/java/org/apache/webbeans/spi/ee/openejb/ > > src/main/java/org/apache/webbeans/spi/ee/openejb/ejb/ > > src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/ > src/test/java/org... > > > An: [email protected] > > > Datum: Donnerstag, 18. Juni 2009, 21:51 > > > Author: gerdogdu > > > Date: Thu Jun 18 19:51:03 2009 > > > New Revision: 786229 > > > > > > URL: http://svn.apache.org/viewvc?rev=786229&view=rev > > > Log: > > > Adding package for EJB stuff. Maybe we can add > EJB > > > integration code here. > > > > > > Added: > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/ejb/ > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/ > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/JPAServiceOpenEJBImpl.java > > > - copied, changed > from r782277, > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/JPAServiceOpenEJBImpl.java > > > Removed: > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/JPAServiceOpenEJBImpl.java > > > Modified: > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/pom.xml > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/java/org/apache/webbeans/test/geronimo/openejb/OpenEJBIntegrationTest.java > > > > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/resources/META-INF/openwebbeans/openwebbeans.properties > > > > > > Modified: > > > > incubator/openwebbeans/trunk/webbeans-geronimo/pom.xml > > > URL: > > http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-geronimo/pom.xml?rev=786229&r1=786228&r2=786229&view=diff > > > > > > ============================================================================== > > > --- > incubator/openwebbeans/trunk/webbeans-geronimo/pom.xml > > > (original) > > > +++ > incubator/openwebbeans/trunk/webbeans-geronimo/pom.xml > > > Thu Jun 18 19:51:03 2009 > > > @@ -43,13 +43,14 @@ > > > > <dependency> > > > > > > > <groupId>junit</groupId> > > > > > > > <artifactId>junit</artifactId> > > > + > > > <scope>test</scope> > > > > </dependency> > > > > > > > <dependency> > > > > > > > <groupId>org.apache.openejb</groupId> > > > > > > > <artifactId>openejb-core</artifactId> > > > + > > > <scope>provided</scope> > > > <!-- > > > > <version>3.1.1-SNAPSHOT</version>--> > > > - > > > <version>3.0.1</version> > > > > </dependency> > > > > > > > <dependency> > > > > > > Copied: > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/JPAServiceOpenEJBImpl.java > > > (from r782277, > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/JPAServiceOpenEJBImpl.java) > > > URL: > > http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/JPAServiceOpenEJBImpl.java?p2=incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/JPAServiceOpenEJBImpl.java&p1=incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/JPAServiceOpenEJBImpl.java&r1=782277&r2=786229&rev=786229&view=diff > > > > > > ============================================================================== > > > --- > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/JPAServiceOpenEJBImpl.java > > > (original) > > > +++ > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/main/java/org/apache/webbeans/spi/ee/openejb/jpa/JPAServiceOpenEJBImpl.java > > > Thu Jun 18 19:51:03 2009 > > > @@ -11,7 +11,7 @@ > > > * KIND, either express or > implied. See the License > > > for the specific language > > > * governing permissions and > limitations under the > > > License. > > > */ > > > -package org.apache.webbeans.spi.ee.openejb; > > > +package org.apache.webbeans.spi.ee.openejb.jpa; > > > > > > import > javax.enterprise.inject.CreationException; > > > import javax.naming.Context; > > > > > > Modified: > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/java/org/apache/webbeans/test/geronimo/openejb/OpenEJBIntegrationTest.java > > > URL: > > http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-geronimo/src/test/java/org/apache/webbeans/test/geronimo/openejb/OpenEJBIntegrationTest.java?rev=786229&r1=786228&r2=786229&view=diff > > > > > > ============================================================================== > > > --- > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/java/org/apache/webbeans/test/geronimo/openejb/OpenEJBIntegrationTest.java > > > (original) > > > +++ > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/java/org/apache/webbeans/test/geronimo/openejb/OpenEJBIntegrationTest.java > > > Thu Jun 18 19:51:03 2009 > > > @@ -23,7 +23,7 @@ > > > import junit.framework.Assert; > > > > > > import > org.apache.webbeans.jpa.spi.JPAService; > > > -import > > > > org.apache.webbeans.spi.ee.openejb.JPAServiceOpenEJBImpl; > > > +import > > > > org.apache.webbeans.spi.ee.openejb.jpa.JPAServiceOpenEJBImpl; > > > import org.junit.Test; > > > > > > > > > > > > Modified: > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/resources/META-INF/openwebbeans/openwebbeans.properties > > > URL: > > http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-geronimo/src/test/resources/META-INF/openwebbeans/openwebbeans.properties?rev=786229&r1=786228&r2=786229&view=diff > > > > > > ============================================================================== > > > --- > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/resources/META-INF/openwebbeans/openwebbeans.properties > > > (original) > > > +++ > > > > > > incubator/openwebbeans/trunk/webbeans-geronimo/src/test/resources/META-INF/openwebbeans/openwebbeans.properties > > > Thu Jun 18 19:51:03 2009 > > > @@ -36,7 +36,7 @@ > > > > > > > > > org.apache.webbeans.spi.TransactionService=org.apache.webbeans.spi.ee.TransactionServiceJndiImpl > > > > > > # use the JPAService which retrieves the > > > PersistenceManagerFactory from the Persistence > class as > > > default > > > > > > -org.apache.webbeans.spi.JPAService=org.apache.webbeans.spi.ee.openejb.JPAServiceOpenEJBImpl > > > > > > +org.apache.webbeans.spi.JPAService=org.apache.webbeans.spi.ee.openejb.jpa.JPAServiceOpenEJBImpl > > > > > > #use the web metadata as default > > > > > > > > > org.apache.webbeans.spi.deployer.MetaDataDiscoveryService=org.apache.webbeans.spi.ee.deployer.WarMetaDataDiscoveryImpl > > > > > > > > > > > > > > > > > > > > -- > Gurkan Erdogdu > http://gurkanerdogdu.blogspot.com >
